-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-118824: Remove deprecated master_open
and slave_open
from pty
#118826
Conversation
Misc/NEWS.d/next/Library/2024-05-09-11-50-26.gh-issue-118824.-jBJQC.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
…m `pty` (python#118826) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
except ImportError: | ||
return master_fd, slave_fd | ||
try: | ||
ioctl(result, I_PUSH, "ptem") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result
is a NameError now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #124406
CC @gpshead who reviewed #92365
master_open
andslave_open
frompty
#118824📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/